Migrate GiftedChat to TypeScript #1190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
=========================================
Coverage ? 34.99%
=========================================
Files ? 20
Lines ? 543
Branches ? 181
=========================================
Hits ? 190
Misses ? 344
Partials ? 9
Continue to review full report at Codecov.
|
|
thanks for this |
|
Hi @EvanBacon! What do you think if we change a bit the examples files structure and make a single app example by merging others? And also do something like @slorber did every time when he makes an RN lib.
|
|
@xcarpentier yeah, I think one example would be best. It'd also be great to make things like react-native-video optional now that Expo (specifically expo-av) has web support. |
|
OK, will do it in another PR. @EvanBacon can you precise your suggestion about web support (ie. expo-av)? |
xcarpentier
removed request for
burgalon,
davidLeonardi,
kfiroo,
FaridSafi,
psyzz,
koppelaar,
sibelius,
cooperka,
brunocascio,
watadarkstar,
wenkesj and
bookercodes
| <View style={this.props.alignTop ? styles.containerAlignTop : styles.container}> | ||
| {this.state.showScrollBottom && this.props.scrollToBottom ? this.renderScrollToBottomWrapper() : null} | ||
| <FlatList | ||
| ref={(ref) => (this.flatListRef = ref)} |
| ? this.renderScrollToBottomWrapper() | ||
| : null} | ||
| <FlatList | ||
| ref={this.flatListRef} |
There was a problem hiding this comment.
Here is an error. This means that when sending a new message, do not scroll down. I am right?
There was a problem hiding this comment.
I you have time make PR, it will be more explicit. Thanks
Migrate the project to TypeScript.
cc @slorber @EvanBacon ;)