Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GiftedChat to TypeScript #1190

Open
wants to merge 12 commits into
base: master
from

Conversation

@xcarpentier
Copy link
Collaborator

xcarpentier commented Apr 5, 2019

Migrate the project to TypeScript.

cc @slorber @EvanBacon ;)

xcarpentier added some commits Jan 29, 2019

@xcarpentier xcarpentier added the pinned label Apr 5, 2019

@xcarpentier xcarpentier requested a review from FaridSafi Apr 5, 2019

@xcarpentier xcarpentier self-assigned this Apr 5, 2019

xcarpentier added some commits Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@66fd0f8). Click here to learn what that means.
The diff coverage is 33.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1190   +/-   ##
=========================================
  Coverage          ?   34.99%           
=========================================
  Files             ?       20           
  Lines             ?      543           
  Branches          ?      181           
=========================================
  Hits              ?      190           
  Misses            ?      344           
  Partials          ?        9
Impacted Files Coverage Δ
src/Constant.ts 100% <ø> (ø)
src/MessageVideo.tsx 0% <0%> (ø)
src/__tests__/context.tsx 100% <100%> (ø)
src/GiftedChat.tsx 12.65% <12.65%> (ø)
src/GiftedAvatar.tsx 13.51% <13.51%> (ø)
src/MessageContainer.tsx 18.46% <18.46%> (ø)
src/Composer.tsx 20% <20%> (ø)
src/MessageText.tsx 33.33% <33.33%> (ø)
src/Actions.tsx 38.46% <38.46%> (ø)
src/Bubble.tsx 47.36% <47.36%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fd0f8...ddbf6c6. Read the comment docs.

@EvanBacon

This comment has been minimized.

Copy link
Contributor

EvanBacon commented Apr 9, 2019

thanks for this

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

xcarpentier commented Apr 12, 2019

Hi @EvanBacon! What do you think if we change a bit the examples files structure and make a single app example by merging others?

And also do something like @slorber did every time when he makes an RN lib.
I mean an expo app at the root and an npm script before publish. It's really more easy for dev cycle of a lib! see it here:

@EvanBacon

This comment has been minimized.

Copy link
Contributor

EvanBacon commented Apr 12, 2019

@xcarpentier yeah, I think one example would be best. It'd also be great to make things like react-native-video optional now that Expo (specifically expo-av) has web support.

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

xcarpentier commented Apr 12, 2019

OK, will do it in another PR.

@EvanBacon can you precise your suggestion about web support (ie. expo-av)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.