Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB Gifted Chat #1284

Open
wants to merge 30 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@xcarpentier
Copy link
Collaborator

commented Jun 26, 2019

Using react-native-web for Gifted Chat.
Next version: next
@EvanBacon

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2faf9c5). Click here to learn what that means.
The diff coverage is 17.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1284   +/-   ##
=========================================
  Coverage          ?   29.96%           
=========================================
  Files             ?       20           
  Lines             ?      624           
  Branches          ?      211           
=========================================
  Hits              ?      187           
  Misses            ?      427           
  Partials          ?       10
Impacted Files Coverage Δ
src/Composer.tsx 20% <ø> (ø)
src/MessageImage.tsx 80% <ø> (ø)
src/LoadEarlier.tsx 57.14% <ø> (ø)
src/QuickReplies.tsx 6.25% <0%> (ø)
src/MessageContainer.tsx 14.11% <0%> (ø)
src/GiftedAvatar.tsx 14.7% <0%> (ø)
src/Message.tsx 40.47% <0%> (ø)
src/GiftedChat.tsx 11.44% <0%> (ø)
src/Constant.ts 100% <100%> (ø)
src/Time.tsx 88.88% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2faf9c5...76982c7. Read the comment docs.

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 26, 2019

There are issues with <ParseText/> to fix it I'm using @EvanBacon PR and for <Video/> I used platform web and require (not yet tested).

@xcarpentier xcarpentier requested a review from brunocascio Jun 28, 2019

@xcarpentier xcarpentier force-pushed the feature/rnw branch from 753fb63 to b94933f Jun 28, 2019

@xcarpentier xcarpentier force-pushed the feature/rnw branch from 7502599 to fd0c430 Jun 28, 2019

@xcarpentier xcarpentier requested a review from cooperka Jul 2, 2019

@xcarpentier xcarpentier self-assigned this Jul 2, 2019

@EvanBacon

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

It would be great to remove the video as it's a native dependancy. If you create an Expo app (which would have universal support) then you are installing react-native-video and not using.

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 3, 2019

@EvanBacon expo-av could do the job, no?
Will you webify it already?
Can we use it as a dependency or is the issue?

@xcarpentier xcarpentier force-pushed the feature/rnw branch from 4b81b87 to ab08d9d Jul 3, 2019

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 3, 2019

I removed video dependency.

@zacharyrose

This comment has been minimized.

Copy link

commented Jul 12, 2019

Very excited for this feature to merge!

@xcarpentier xcarpentier force-pushed the feature/rnw branch from d827601 to 76982c7 Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.