Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Body Scan item doesn't open GMAIL #1053

Closed
slspencer opened this issue Dec 18, 2023 · 10 comments · Fixed by #1057
Closed

BUG: Body Scan item doesn't open GMAIL #1053

slspencer opened this issue Dec 18, 2023 · 10 comments · Fixed by #1057
Assignees
Labels

Comments

@slspencer
Copy link
Collaborator

slspencer commented Dec 18, 2023

  • The Body Scan menu item doesn't open the Gmail tab in Chrome on Windows 10
  • To enable Chrome to open the GMail tab, users have to change their Chrome settings to enable the 'Sites can ask to handle protocols' setting.

Set-chrome-protocol-handlers

@slspencer
Copy link
Collaborator Author

Here's the PR:
#1052

@slspencer slspencer changed the title BUG: Body Scan menu item missing BUG: Body Scan item doesn't open GMAIL Dec 19, 2023
@slspencer
Copy link
Collaborator Author

@DSCaskey - I updated this issue to be the correct problem. If users have Gmail and use Chrome, then SeamlyMe opens a new instance of Chrome with a blank tab.

@slspencer
Copy link
Collaborator Author

slspencer commented Dec 19, 2023

We could change the approach.

  1. Ask the user to select their file with a File Explorer, then use cURL to send the file as an attachment using SMTP and cURL and a Cloud provider as described here: https://blog.ambor.com/2021/08/using-curl-to-send-e-mail-with.html , https://github.com/ambanmba/send-ses

  2. Ask the user to send their file to convert@seamly.io

@DSCaskey
Copy link
Contributor

Or

  1. Do it on the server side - Just like any of the umpteen file conversion sites out there - and just call the link from SeamlyME.

@DSCaskey
Copy link
Contributor

Ask the user to select their file with a File Explorer, then use cURL to send the file as an attachment using SMTP and cURL and a Cloud provider as described here:

Downside here is that we then have to package curl with the releases. Not that big a deal if it works.

Let me play with this tomorrow, and see if itcan work... or maybe it will give me insight into how I can implement within Qt without curl along the lines I originally intended.

@DSCaskey
Copy link
Contributor

Again... not sure if this is going to work... you need the AWS credentials to make it work and:

From the blog github to use the script...
"Setup
You need to get SMTP Credentials from Amazon SES which will include an Access Key (beginning with AK) and a secret."

From Amazon:
"The credentials that you use to send email through the SES SMTP interface are unique to each AWS Region. If you use the SES SMTP interface to send email in more than one Region, you must generate a set of SMTP credentials for each Region that you plan to use."

In other words we can't just use Amazon (or what ever server) to send anonymous emails.

@csett86
Copy link
Collaborator

csett86 commented Dec 19, 2023

Bundling AWS credentials in the app (and in the source code here) does not sound like a great idea, as these would leak and thus be abused (and then probably blocked by AWS).

I suggest to "just" instruct the user for now to send the file to the email address without and opening of email programs. Many users I know use just webmail in the browser and no email program, so trying to open that is close to impossible. Thus I would keep it with instructions only

@DSCaskey
Copy link
Contributor

DSCaskey commented Dec 19, 2023 via email

@FashionFreedom FashionFreedom deleted a comment from DSCaskey Dec 28, 2023
@slspencer
Copy link
Collaborator Author

I agree, tell the user in clear large font in the intro Splash screen and in SeamlyMe to send their file to convert@seamly.io.

@slspencer
Copy link
Collaborator Author

@DSCaskey Please add the instruction to send body scan measurement files to convert@seamly.io on the Splash screen.

BECAUSE...Several hundred people have checked out the body scanner partner's website using the SEAMLY50 discount code. But we haven't received any conversion requests yet via email. I suspect this is because they don't know what to do. Almost everyone uses a browser-based email program, so this issue is a big barrier for us.

The email conversion program is running in Google Cloud, we need to send people to it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bug Hunt - SeamlyMe
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants