-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add seamlyme welcome screen #1057
Conversation
Dont open main window twice, revert to old processCommandLine logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good, I just did small fixups (reverting to the old immediate processing of the commandline args to avoid two seamly windows under macos) and removing the splash screen leftovers
mac build is failing due to a missing updated agreement in the Apple developer account:
@slspencer could you please help us out here at https://developer.apple.com/account |
Since the delay = 0, just call slot directly..
Since the delay = zero, we can just remove the QTimer call processCommandLine() directly. Also moved the "NOTing" of showWelcome in the assignment. Makes it a bit clearer. If showWelcome was used more than once, would have to NOT every occurance. |
For some reason without the QTimer call even with a zero delay, is causing the seamlyME commandline tests to fail.
For some reason removing the QTimer call in main() is causing the SeamlyMe command line tests to fail?? Makes no sense, but just putting back the way it was. |
I also did not follow through on the timer, just reverted it to the old value (same as you) |
This adds a Welcome screen dialog in place of the existing Splash screen. Offers more options and control than a QSplashScreen does.
Resolves issue #1053