Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add seamlyme welcome screen #1057

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Jan 5, 2024

This adds a Welcome screen dialog in place of the existing Splash screen. Offers more options and control than a QSplashScreen does.

  • Allows for form layout with more than a single message. The existing splash screen was just a background pixmap, which lacks the ability to translate.
  • Has an OK button that is user dependent and does not rely on a timed delay.
  • Allows for the user to choose whether to see the dialog again.
  • Adds some default startup user prefs such as the Decimal separator that has been an issue for some new users when not set correctly. CheckBox text changes from "Use OS options" to "User locale"
  • Specifically addresses the 3D Look body scan conversion. Also removes the code to attempt creating a conversion email.

welcome

Resolves issue #1053

@ghost
Copy link

ghost commented Jan 5, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Dont open main window twice, revert to old processCommandLine logic
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good, I just did small fixups (reverting to the old immediate processing of the commandline args to avoid two seamly windows under macos) and removing the splash screen leftovers

@csett86
Copy link
Collaborator

csett86 commented Jan 6, 2024

mac build is failing due to a missing updated agreement in the Apple developer account:

Error: HTTP status code: 403. A required agreement is missing or has expired. This request requires an in-effect agreement that has not been signed or has expired. Ensure your team has signed the necessary legal agreements and that they are not expired.

@slspencer could you please help us out here at https://developer.apple.com/account

Bildschirmfoto 2024-01-06 um 22 05 33

Since the delay = 0, just call slot directly..
@DSCaskey
Copy link
Contributor Author

DSCaskey commented Jan 7, 2024

@csett86

reverting to the old immediate processing of the commandline args to avoid two seamly windows under macos

Since the delay = zero, we can just remove the QTimer call processCommandLine() directly.

Also moved the "NOTing" of showWelcome in the assignment. Makes it a bit clearer. If showWelcome was used more than once, would have to NOT every occurance.

For some reason without the QTimer call  even with a zero delay, is causing the seamlyME commandline tests to fail.
@DSCaskey
Copy link
Contributor Author

DSCaskey commented Jan 7, 2024

@csett86

For some reason removing the QTimer call in main() is causing the SeamlyMe command line tests to fail?? Makes no sense, but just putting back the way it was.

@csett86
Copy link
Collaborator

csett86 commented Jan 7, 2024

I also did not follow through on the timer, just reverted it to the old value (same as you)

@slspencer slspencer merged commit 133eaab into develop Jan 9, 2024
10 checks passed
@slspencer slspencer deleted the update-Me-splash-screen-and-import-dialog branch January 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Body Scan item doesn't open GMAIL Feature: add splash screeen to SeamlyMe
3 participants