Cleanup XorPlus8 + guard against infinite loop in table construction #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasmueller could you take a look? This PR contains the infinite loop guard proposed in the discussion of #30. I also took the opportunity to read through the code to make sure I understood all of it, and along the way I made a few other small changes. |
steve-scalyr
commented
Oct 14, 2021
| @@ -110,7 +102,6 @@ public XorPlus8(int size, byte[] fingerprints) { | |||
| public XorPlus8(long[] keys) { | |||
| this.size = keys.length; | |||
| this.arrayLength = getArrayLength(size); | |||
| this.bitCount = arrayLength * BITS_PER_FINGERPRINT; | |||
There was a problem hiding this comment.
This value is never read; a new value is written near the end of the method.
thomasmueller
approved these changes
Oct 15, 2021
|
Thanks! One last request: would it be possible to publish a new release (1.0.3) now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes to the
XorPlus8class:this.when assigning instance fields in constructorbitCount; remove an unused constructor that was assigning it incorrectlyRegarding the unused constructor that I removed: it did not populate
seedorrank, and I believe the latter means that any attempt to use the instance created by this constructor would have resulted inNullPointerException.The changes are small, but can most easily be reviewed one commit at a time.