Cleanup XorPlus8 + guard against infinite loop in table construction #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes to the
XorPlus8
class:this.
when assigning instance fields in constructorbitCount
; remove an unused constructor that was assigning it incorrectlyRegarding the unused constructor that I removed: it did not populate
seed
orrank
, and I believe the latter means that any attempt to use the instance created by this constructor would have resulted inNullPointerException
.The changes are small, but can most easily be reviewed one commit at a time.