Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download extension icons in readme #1180

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Update download extension icons in readme #1180

merged 2 commits into from
Oct 15, 2023

Conversation

SecretX33
Copy link
Contributor

@SecretX33 SecretX33 commented Oct 14, 2023

Issue: #1160

As stated in the Issue, I have both the square and rounded versions of the Chrome icon, here in this PR I opted to use the squared version (to be as similar as possible to the current icon), but I personally think the round icon looks the best, so maybe we could switch to that.

Another thing to note in this PR is that the colors of the old and new Firefox download icon are slightly different (the new one has a darker blue), but that is easy to modify since it is a high-quality PNG picture, it is a matter of copying the color of the old icon and applying it on the new one using Paint/Photoshop.

And last but not least, I wasn't sure what the convention for icons is for FastForward. I wasn't sure if the icons should be somewhere in the project's folder (like in the docs folder), or if it should be hosted externally. Since the current icons being used are from user-images.githubusercontent.com , I assumed the project wants to keep its icons externalized, so I uploaded them to imgur.com (but no clue if this was the preferred way).

Here's the upload link with all three icons: https://imgur.com/a/2luHAqC

Fix(es):
There was no fix, this PR updates the Firefox and Chrome download icons in the project readme.

  • I made sure there are no unnecessary changes in the code;
  • Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
  • Tested on Firefox.

@NotAProton
Copy link
Member

using the https://github.com/FastForwardTeam/assets repo would be preferred instead of imgur but we'll have to edit it's readme

The respective authors of all files in this repository have, to the extent possible under law, waived all copyright and related or neighboring rights to the files.

to say that the files in the logo and logo_new are under CC0 and the Chrome, Edge and Firefox logo in the ext directory are the property of their respective owners.

@driedpampas
Copy link
Contributor

FastForwardTeam/Assets#2

@github-actions
Copy link

Download the artifacts for this pull request:

Copy link
Contributor

@lostdusty lostdusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, not like imgur will die soon.

@undeadjess undeadjess merged commit 13febe5 into FastForwardTeam:main Oct 15, 2023
3 checks passed
@SecretX33 SecretX33 deleted the patch/readme-download-ext-icons branch October 20, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants