-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastLED as ESP-IDF component support #1352
Conversation
Enables FastLED as ESP-IDF component support (with Arduino as component)
I should have been more verbose ;) This library already has a component.mk file but for full CMake support the CMakeLists.txt is also needed. That is especially useful if you want to use the ESP-IDF for the ESP32 (and its variants) for example, as they make use of CMake. That way you have more control but you also need to add all the 3rd party libraries as "components". Probably the most useful to start with is ESP32-Arduino but if you also want to use proven and loved libraries (like this one) you need to add the CMake files manually if they do not exist (what took me a bit to understand how it works). Some libraries like ESP32-HUB75-MatrixPanel-I2S-DMA already implemented support, so I hope this one will too :) |
@solhuebner Thank you for your contribution! Would you mind taking a look at the related issue submitted by another user? I have not had a chance to look closely at it myself, but #1380 shows the compile problems. |
Hello @samguyer, the compile issues when targeting the ESP32-S3 has been traced to a missing |
|
Thanks. I will have a look over the weekend and update the PR. |
Add clockless to CMakeLists.txt
@JustinOng I added it as requested. Can you please test it? |
Looks good to me, thank you! At the moment, I'm just manually adding in your
|
Thank you -- this is a great piece of support to have contributed. Thanks for helping out with FastLED! |
Enables FastLED as ESP-IDF component support (with Arduino as component)