Fix the F_CPU frequency definition for the ESP32-S3 in esp32-hal.h

[devrim-oguz]

Description of Change

Hello, I was using the FastLED library and it was complaining about F_CPU not being defined. So, I just noticed that it is not defined for the ESP32-S3 module. So I made this change in the header file and it compiled. Therefore I wanted to propose this change to the HAL library to improve compatibility. Thank you for your time.

Tests scenarios

I have tested this with the ESP32-S3-WROOM-1-N16R2 module for the FastLED library. Haven't done any extensive testing since it is a trivial change (I hope).

#Fix #8005

[CLAassistant]

All committers have signed the CLA.

[mrengineer7777]

Interesting. LGTM. I wonder if C3 and other variants also need an entry?

[devrim-oguz]

Interesting. LGTM. I wonder if C3 and other variants also need an entry?

They probably would need to. And every single board that comes after. This is not a good way of doing it tbh, but that's how its defined in the sdkconfig. The interesting thing is that this error does not occur in PlatformIO, probably because it gets defined in somewhere else and this part is skipped. But it does so in esp-idf when arduino used as a component. So this is how I solved it for my own application. It would be better if the other boards are added to this, but I didn't look much about how many other variants there are.

[SuGlider]

Interesting. LGTM. I wonder if C3 and other variants also need an entry?

They probably would need to. And every single board that comes after. This is not a good way of doing it tbh, but that's how its defined in the sdkconfig. The interesting thing is that this error does not occur in PlatformIO, probably because it gets defined in somewhere else and this part is skipped. But it does so in esp-idf when arduino used as a component. So this is how I solved it for my own application. It would be better if the other boards are added to this, but I didn't look much about how many other variants there are.

@mrengineer7777 @devrim-oguz

I just modified the PR to be generic, based on the sdkconfig definition of each SoC.
It shall now work for the ESP32, ESP32S2, ESP32C3 and ESP32S3.

@devrim-oguz - please test and confirm that it works for the FastLED library with the S3.

[SuGlider]

Interesting. LGTM. I wonder if C3 and other variants also need an entry?

They probably would need to. And every single board that comes after. This is not a good way of doing it tbh, but that's how its defined in the sdkconfig. The interesting thing is that this error does not occur in PlatformIO, probably because it gets defined in somewhere else and this part is skipped. But it does so in esp-idf when arduino used as a component. So this is how I solved it for my own application. It would be better if the other boards are added to this, but I didn't look much about how many other variants there are.

@mrengineer7777 @devrim-oguz

I just modified the PR to be generic, based on the sdkconfig definition of each SoC. It shall now work for the ESP32, ESP32S2, ESP32C3 and ESP32S3.

@devrim-oguz - please test and confirm that it works for the FastLED library with the S3.

OK... Actually the fix I did works for the IDF 5.1 and Arduino 3.0.0.
For Arduino 2.0.8, it shall follow the previous model.
Let me create 2 PRs, one for each Arduino Core version.

[SuGlider]

Just added also support to ESP32C3.
Thanks @devrim-oguz and @mrengineer7777 !

[devrim-oguz]

Just added also support to ESP32C3. Thanks @devrim-oguz and @mrengineer7777 !

Thank you for making it available for everyone

[mrengineer7777]

LGTM