Tiny tweaks wrt suggested changes

FasterXML · Feb 15, 2024 · 548db8a · 548db8a
1 parent 3a1342b
commit 548db8a
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 7 deletions.
diff --git a/src/main/java/com/fasterxml/jackson/core/JsonFactory.java b/src/main/java/com/fasterxml/jackson/core/JsonFactory.java
@@ -46,6 +46,7 @@
 @SuppressWarnings("resource")
 public class JsonFactory
     extends TokenStreamFactory
+    implements java.io.Serializable
 {
     private static final long serialVersionUID = 2;
 

diff --git a/src/main/java/com/fasterxml/jackson/core/JsonParser.java b/src/main/java/com/fasterxml/jackson/core/JsonParser.java
@@ -1279,7 +1279,7 @@ public Boolean nextBooleanValue() throws IOException {
      * @since 2.8
      */
     public void finishToken() throws IOException {
-         // nothing
+        // nothing to do
     }
 
     /*

diff --git a/src/main/java/com/fasterxml/jackson/core/Version.java b/src/main/java/com/fasterxml/jackson/core/Version.java
@@ -82,7 +82,7 @@ public Version(int major, int minor, int patchLevel, String snapshotInfo,
     public boolean isUnknownVersion() { return (this == UNKNOWN_VERSION); }
 
     public boolean isSnapshot() {
-        return (_snapshotInfo != null) && (!_snapshotInfo.isEmpty());
+        return (_snapshotInfo != null) && !_snapshotInfo.isEmpty();
     }
 
     /**

diff --git a/src/main/java/com/fasterxml/jackson/core/base/ParserBase.java b/src/main/java/com/fasterxml/jackson/core/base/ParserBase.java
@@ -1055,7 +1055,7 @@ protected void convertNumberToInt() throws IOException
         if ((_numTypesValid & NR_LONG) != 0) {
             // Let's verify its lossless conversion by simple roundtrip
             int result = (int) _numberLong;
-            if ((result) != _numberLong) {
+            if (result != _numberLong) {
                 reportOverflowInt(getText(), currentToken());
             }
             _numberInt = result;

diff --git a/src/main/java/com/fasterxml/jackson/core/json/UTF8JsonGenerator.java b/src/main/java/com/fasterxml/jackson/core/json/UTF8JsonGenerator.java
@@ -822,7 +822,7 @@ private final void _writeSegmentedRaw(char[] cbuf, int offset, int len) throws I
             inner_loop:
             while (true) {
                 int ch = cbuf[offset];
-                if (ch >= 0x80) {
+                if (ch > 0x7F) {
                     break inner_loop;
                 }
                 // !!! TODO: fast(er) writes (roll input, output checks in one)

diff --git a/src/main/java/com/fasterxml/jackson/core/util/TextBuffer.java b/src/main/java/com/fasterxml/jackson/core/util/TextBuffer.java
@@ -1150,7 +1150,8 @@ private char[] resultArray() throws IOException
         int offset = 0;
         final char[] result = carr(size);
         if (_segments != null) {
-            for (char[] curr : _segments) {
+            for (int i = 0, len = _segments.size(); i < len; ++i) {
+                char[] curr = _segments.get(i);
                 int currLen = curr.length;
                 System.arraycopy(curr, 0, result, offset, currLen);
                 offset += currLen;

diff --git a/src/main/java/com/fasterxml/jackson/core/util/VersionUtil.java b/src/main/java/com/fasterxml/jackson/core/util/VersionUtil.java
@@ -69,8 +69,9 @@ public static Version versionFor(Class<?> cls)
             } catch (Exception e) {
                 throw new IllegalArgumentException("Failed to get Versioned out of "+vClass);
             }
-        } catch (Exception e) { // ok to be missing (not good but acceptable)
-
+        } catch (Exception e) {
+            // ok to be missing (not good but acceptable)
+            ;
         }
         return (v == null) ? Version.unknownVersion() : v;
     }