Make one addition to RecyclerPool.WithPool to ensure "release" meth…

…od implemented (#1126)

src/main/java/com/fasterxml/jackson/core/io/IOContext.java

@@ -464,7 +464,7 @@ private IllegalArgumentException wrongBuf() {
     @Override
     public void close() {
         if (!_closed) {
-            _bufferRecycler.release();
+            _bufferRecycler.releaseToPool();
             _closed = true;
         }
     }

src/main/java/com/fasterxml/jackson/core/util/BufferRecycler.java

@@ -197,6 +197,12 @@ protected int charBufferLength(int ix) {
     protected byte[] balloc(int size) { return new byte[size]; }
     protected char[] calloc(int size) { return new char[size]; }
 
+    /*
+    /**********************************************************
+    /* WithPool implementation
+    /**********************************************************
+     */
+
     /**
      * Method called by owner of this recycler instance, to provide reference to
      * {@link RecyclerPool} into which instance is to be released (if any)
@@ -205,7 +211,7 @@ protected int charBufferLength(int ix) {
      */
     @Override
     public BufferRecycler withPool(RecyclerPool<BufferRecycler> pool) {
-        if (this._pool != null) {
+        if (_pool != null) {
             throw new IllegalStateException("BufferRecycler already linked to pool: "+pool);
         }
         // assign to pool to which this BufferRecycler belongs in order to release it
@@ -220,7 +226,8 @@ public BufferRecycler withPool(RecyclerPool<BufferRecycler> pool) {
      *
      * @since 2.16
      */
-    public void release() {
+    @Override
+    public void releaseToPool() {
         if (_pool != null) {
             RecyclerPool<BufferRecycler> tmpPool = _pool;
             // nullify the reference to the pool in order to avoid the risk of releasing

src/main/java/com/fasterxml/jackson/core/util/JsonRecyclerPools.java

@@ -25,6 +25,7 @@ public final class JsonRecyclerPools
     public static RecyclerPool<BufferRecycler> defaultPool() {
         return threadLocalPool();
     }
+
     /**
      * Accessor for getting the shared/global {@link ThreadLocalPool} instance
      * (due to design only one instance ever needed)

src/main/java/com/fasterxml/jackson/core/util/RecyclerPool.java

@@ -46,7 +46,21 @@ public interface RecyclerPool<P extends RecyclerPool.WithPool<P>> extends Serial
      * @param <P> Self type
      */
     public interface WithPool<P extends WithPool<P>> {
+        /**
+         * Method to call to add link from pooled item back to pool
+         * that handles it
+         * 
+         * @param pool Pool that "owns" pooled item
+         *
+         * @return This item (for call chaining)
+         */
         P withPool(RecyclerPool<P> pool);
+
+        /**
+         * Method called when this item is to be released back to the
+         * pool that owns it (if any)
+         */
+        void releaseToPool();
     }
 
     /**

src/test/java/com/fasterxml/jackson/core/io/BufferRecyclerPoolTest.java

@@ -51,7 +51,7 @@ private void checkBufferRecyclerPoolImpl(RecyclerPool<BufferRecycler> pool,
             try {
                 assertSame(usedBufferRecycler, pooledBufferRecycler);
             } finally {
-                pooledBufferRecycler.release();
+                pooledBufferRecycler.releaseToPool();
             }
         }
     }