Issue #455 getCurrentLocation() incorrect at end of input #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string at end of input Fixes the getCurrentLocation() issue by moving changes to _currInputProcessed and _currInputRowStart inside successful branch. Also includes checks for getTokenLocation() that make sure correct beginning location of tokens is reported and that getCurrentLocation() correctly reports the end of stream when reading is finished. Tests would be much nicer with parameterized tests from Junit5 since it's hard to tell which test case fails if one does. That's what the commented out print statements are for. Let me know if you'd like something different, but I originally had them separated out and forgot to add methods when I added to the enum. Also, the idea for the enum and much of the test data is from https://github.com/leadpony/jsonp-test-suite, which is also Apache 2 licensed. I had to rework the expected results because the JsonP getLocation() works very differently. Let me know if you need a CLA from the author of that project and I'll approach him.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the getCurrentLocation() issue (#455) by moving changes to _currInputProcessed,
_currInputRowStart, and _nameStartOffset inside successful branch. Also includes
checks for getTokenLocation() that make sure correct beginning location of tokens is
reported and that getCurrentLocation() correctly reports the end of
stream when reading is finished.
Tests would be much nicer with parameterized tests from Junit5 since it's
hard to tell which test case fails if one does. That's what the commented
out print statements are for. Let me know if you'd like something different,
but I originally had them separated out and forgot to add methods when I
added to the enum.
Also, the idea for the enum and much of the test data is from
https://github.com/leadpony/jsonp-test-suite, which is also Apache 2
licensed. I had to rework the expected results because the JsonP
getLocation() works very differently. Let me know if you need a
CLA from the author of that project and I'll approach him.