-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex escapes should allow lower- or upper-case letters A-F #1
Comments
Hello @toddobryan |
Now I identified the error location. |
Sorry about that. I wasn't sure the right way to fix it or I would have given it a try. |
It's OK. I will fix the problem in a few days. |
HI @toddobryan <dependency>
<groupId>org.leadpony</groupId>
<artifactId>jsonp-test-suite</artifactId>
<version>master-SNAPSHOT</version>
</dependency> |
Will do. Thanks again! Also, this suite caught a mistake in Jackson Core for which I've submitted a pull request: FasterXML/jackson-core#557 I leaned heavily on your test structure, but had to change it a bit because of the difference in the way Jackson specifies locations. I may have borrowed enough of your code that they'd like you to provide a contributor license agreement, if you don't mind. If you do mind, I'll rework everything so that it doesn't depend on your code. |
Works like a charm now! Thank you! |
Hello @toddobryan |
Since the tests aren't distributed with the library, they were okay with them. Here's the commit...if there's anything in there that you would like me to remove, let me know. |
The reason this even exists is that I was working on a JSON-P implementation based on Jackson, so your tests caught problems in Jackson that I had converted to JSON-P. I've reached the point where a lot of the Jackson conversion is done, but there's still a lot of JSON-P to implement--all of the Patch, Pointer, etc., stuff that really seems like, once you've converted from another representation into the I was thinking of using Joy for that, but wanted to make sure that you don't object. The idea would be that I'd implement |
No I don't object to it. |
Major apologies. I should not have posted those files. I just copied them because I was too lazy to figure out how to run the tests by depending on the jar and don't intend them to be part of the final repo. I'm traveling this weekend, but as soon as I get home, I'll create a new repo without the file, and will add a README with a big thank you for the test suite. Also, if you'd prefer I not use issue comments for communication, my email is toddobryan@gmail.com and I'd be happy to use email instead. |
@toddobryan |
I close this issue because the bug is fixed in the latest release 1.4.0. Please see also the changelog. |
I'm checking an implementation of JsonP I'm writing based on Jackson and got these two errors:
Both of these should be correct, I think.
I can't change the escaping because I'm relying on the underlying Jackson code.
The text was updated successfully, but these errors were encountered: