Skip to content

Commit

Permalink
Fix #3659: add animal-sniffer task (to be run with "mvn animal-sniffe…
Browse files Browse the repository at this point in the history
…r:check") to verify Android SDK compat (#3660)
  • Loading branch information
cowtowncoder committed Nov 13, 2022
1 parent 1b65876 commit 380d62b
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
31 changes: 30 additions & 1 deletion pom.xml
Expand Up @@ -41,6 +41,15 @@
<javac.src.version>1.8</javac.src.version>
<javac.target.version>1.8</javac.target.version>

<!-- 12-Nov-2022, tatu: [databind#3659] Verify Android SDK compatibility.
Baseline compatibility:
* Jackson 2.13 compatible with Android SDK 19 and up
-->
<version.android.sdk>19</version.android.sdk>
<version.android.sdk.signature>0.5.0</version.android.sdk.signature>

<!-- Can not use default, since group id != Java package name here -->
<osgi.export>com.fasterxml.jackson.databind.*;version=${project.version}</osgi.export>
<!-- fix for databind#2299: using jackson-databind in an OSGi environment under Android -->
Expand Down Expand Up @@ -118,7 +127,6 @@

<build>
<plugins>

<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
Expand Down Expand Up @@ -218,6 +226,27 @@
</platformDependencies>
</configuration>
</plugin>

<!-- 12-Nov-2022, tatu: [databind#3659] add verification of compatibility
wrt Android SDK versions using AnimalSniffer with "gummy bears" signatures.
To be run from CI, but manually with:
mvn animal-sniffer:check
-->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.22</version>
<configuration>
<signature>
<groupId>com.toasttab.android</groupId>
<artifactId>gummy-bears-api-${version.android.sdk}</artifactId>
<version>${version.android.sdk.signature}</version>
</signature>
</configuration>
</plugin>

</plugins>
</build>

Expand Down
5 changes: 5 additions & 0 deletions release-notes/VERSION-2.x
Expand Up @@ -4,6 +4,11 @@ Project: jackson-databind
=== Releases ===
------------------------------------------------------------------------

(not yet released)

#3659: Improve testing (likely via CI) to try to ensure compatibility with
specific Android SDKs

2.13.4.2 (13-Oct-2022)

#3627: Gradle module metadata for `2.13.4.1` references non-existent
Expand Down

0 comments on commit 380d62b

Please sign in to comment.