Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "primary mix-in" to AnnotatedFieldCollector from AnnotatedClass #2043

Closed
cowtowncoder opened this issue May 18, 2018 · 0 comments
Closed
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented May 18, 2018

A very minor inefficiency is that whereas AnnotatedMethodCollector is passed the primary mix-in explicitly, field collector isn't. But it probably should. While doing this, may also see if supertype information could/should be passed.

Oh, and the reason? Avoid one more lookup for known information; not just/mostly for cost (simpleish function call, lookup), but to reduce any chance of dynamic lookup producing different result (single canonical evaluation).

@cowtowncoder cowtowncoder added 3.x Issues to be only tackled for Jackson 3.x, not 2.x ACTIVE and removed ACTIVE labels May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Projects
None yet
Development

No branches or pull requests

1 participant