Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree support for JSON patch operations #392

Closed
jgustie opened this issue Jan 25, 2014 · 1 comment
Closed

Tree support for JSON patch operations #392

jgustie opened this issue Jan 25, 2014 · 1 comment

Comments

@jgustie
Copy link

jgustie commented Jan 25, 2014

The JSON pointer implementation in 2.3 is a big part of an RFC 6902 patch implementation. I was hoping maybe to also see add(JsonPointer, JsonNode) and remove(JsonPointer) methods on JsonNode. All of the operations in the spec can be built on top of these in a higher level JSON patch implementation.

It looks like the mutating operations are usually further down in the array and object node implementations, but I thought maybe it made sense for the patch operations that take a JsonPointer to be on JsonNode to make them easier to call.

@cowtowncoder
Copy link
Member

The main design criteria here is that JsonNode only contains read methods, not mutation methods. This allows potential immutable JsonNode implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants