Introduce config override for includeAsProperty (#1522) #1564
Conversation
CarstenWickner
force-pushed
the
config-override_include-as-prop
branch
from
8b8093c
to
beafa77
Compare
| * | ||
| * @since 2.8.8 | ||
| */ | ||
| public abstract JsonInclude.Value getDefaultPropertyInclusion(Class<?> baseType, |
There was a problem hiding this comment.
This is a breaking change, so could not introduce in a patch for sure, and not really in a patch either. Could of course add a new method, deprecate old one, add bridge method.
But what is the meaning of additional type argument here? Why is baseType not sufficient? I thought it was meant specifically as the type for lookups.
There was a problem hiding this comment.
Agreed, that it shouldn't be merged as-is. As mentioned on the initial PR comment, this is just intended to be a proof-of-concept.
As far I understood the usage of these methods, the baseType refers to the type of bean containing the property and the additional type argument refers to the type of the property itself. The existing methods cannot look up the override configuration for a single property as they are not aware of its type.
|
Closing this pull requests, as the respective changes are now applied based on the current version 2.9 in a new pull request #1566. |
@cowtowncoder this is a proof-of-concept how I'd image the include override per property type to work.
Unfortunately, I cannot be sure to have covered all relevant places due to the existing complexity of the databind library. However I hope it is helpful.
Since I couldn't build the current master branch without further setup, I based this on the 2.8 branch.