Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Array node#set methods #3156

Merged
merged 2 commits into from May 28, 2021
Merged

Conversation

TarekkMA
Copy link
Contributor

Closes #3154

The issue I see is that public JsonNode set(int index, JsonNode value) doesn't return the ArrayNode back to the caller.

I don't know if we should add setNode version that will be able to do chaining.

@cowtowncoder
Copy link
Member

Thank you!
Please rebase against 2.13: master is for Jackson 3.0 which will not be out for a while.

Also: if I haven't yet asked for a CLA, I would need one from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(if I already have gotten one no need to send again; this only needs to be done once)

The usual way is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.

@TarekkMA TarekkMA changed the base branch from master to 2.13 May 16, 2021 17:46
@TarekkMA
Copy link
Contributor Author

Oh, I did rebase against it but forget to select the correct branch when opening a PR. it should be correct now.

I will sign the CLA and email it today.

@cowtowncoder
Copy link
Member

CLA received so that's good.

I will be out of town untl next tuesday so will not be able to merge this in until then, but will look into it afterwards.
Thank you very much for contributing the idea and implementation!

@cowtowncoder cowtowncoder added this to the 2.13.0 milestone May 28, 2021
@cowtowncoder
Copy link
Member

Looks good, merging...

@cowtowncoder cowtowncoder merged commit 884a050 into FasterXML:2.13 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ArrayNode#set(int index, primitive_type value)
2 participants