Fix : Case insensitive and number based enum deserialization

[JooHyukKim]

Summary

• resolves Case-insensitive and number-based enum deserialization are (unnecessarily) mutually exclusive #3638

Description

• action : move if (!ctxt.isEnabled(DeserializationFeature.FAIL_ON_NUMBERS_FOR_ENUMS) && !_isFromIntValue) { part to outer.
• pros : From code quality and future maintenance perspective, looks cleaner.
• cons : Backward compatibility, we cannot assume how many systems rely on this issue-turned-into-specification.

[JooHyukKim]

cons : Backward compatibility, we cannot assume how many systems rely on this issue-turned-into-specification.

For above reason, if we are not confident about test cases, we might want to approach like below.

        } else {
            if (Boolean.TRUE.equals(_caseInsensitive)) {
                Object match = lookup.findCaseInsensitive(name);
                if (match != null) {
                    return match;
                }
                // newly added ----------------------------------------
                if (!ctxt.isEnabled(DeserializationFeature.FAIL_ON_NUMBERS_FOR_ENUMS)
                        && !_isFromIntValue) {
                    << same index parsing logic like below >>
                }
            } else if (!ctxt.isEnabled(DeserializationFeature.FAIL_ON_NUMBERS_FOR_ENUMS)
                    && !_isFromIntValue) {
                << index parsing logic that already existed >>
            }
        }

[pjfanning]

If anyone upgrades jackson and have been inadvertently relying on the broken logic in the old versions, they can change their mapper config to fix things (by changing which DeserializationFeatures they set).

[JooHyukKim]

If anyone upgrades jackson and have been inadvertently relying on the broken logic in the old versions, they can change their mapper config to fix things (by changing which DeserializationFeatures they set).

True true 👍🏻 Thanks, @pjfanning !

[cowtowncoder]

Going forward, let's just expose Exception -- this only because 3.0 (master) removes JsonProcessingException (and makes Jackson exceptions unchecked) and using Exception removes one incompatibility wrt merging of changes.
(I'll change this no need to modify PR)

[cowtowncoder]

Thank you @JooHyukKim !