Added new UNWRAP_SINGLE_VALUE_ARRAYS DeserializationFeature #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue FasterXML#381. Added new feature that determines whether it is acceptable to coerce a single value array (in JSON) to the corresponding value type.
Added fix to BeanDeserializerBase that when deserializing a bean, if the UNWRAP_SINGLE_VALUE_ARRAYS feature is enabled, to unwrap a single element array automatically.
Added test cases for single value arrays bean deserialization
| * feature. If more than one value is found in the array, a JsonMappingException is thrown. | ||
| * <p> | ||
| * Feature is disabled by default | ||
| */ |
There was a problem hiding this comment.
Could you add @since 2.4 so javadocs include that as a note?
|
Whops. I did not immediatelly connect the dots wrt email address. Just processing the CLA. So never mind; will merge this PR soon. |
cowtowncoder
added a commit
that referenced
this pull request
Jan 10, 2014
Added new UNWRAP_SINGLE_VALUE_ARRAYS DeserializationFeature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue # 381
By default the new feature is disabled but if enabled (i.e. "objectMapper.enable(DeserializationFeature.UNWRAP_SINGLE_VALUE_ARRAYS);"), any data bind to single element values (i.e. not a list or array) will allow the JSON to contain a single element array and will automatically unwrap that array value. See issue for more detailed information.
For example, let's say you had a class:
public class FooBean { public String bar; }
Without the feature enabled the deserializing following JSON into a FooBean would throw a JsonMappingException:
{ "bar" : [ "barValue" ] }
with the feature enabled, JSON processing would be successful and the FooBean would have the "bar" field set to "barValue".
However:
{ "bar" : [ "barValue", "barValue2" ] } (i.e. if the array contains more than a single element)
would still throw a JsonMappingException
All deserializers supported by jackson-databind have been updated to support the new feature.
Custom JsonDeserializer(s) developed externally to jackson-databind will need to be updated to read this feature's configured value to mimic identical behavior. However since the StdDeserializer and FromStringDeserializer have been updated, any custom deserializers that extend from those classes may function with the new feature without any modification.