Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance StdNodeBasedDeserializer to facilitate usage with ObjectMapper#readerForUpdating #3860

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Apr 5, 2023

Description

This PR enhances StdNodeBasedDeserializer to simplify the usage of ObjectMapper#readerForUpdating by eliminating the need to manually convert the value to a JsonNode.

Changes Made

  • Adds a new convert(JsonNode, DeserializationContext, T) method that supports the readerForUpdating method.
  • Overrides deserialize(JsonParser, DeserializationContext, T) method to support the new convert method.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you @JooHyukKim !

@cowtowncoder cowtowncoder merged commit aeffef7 into FasterXML:2.15 Apr 6, 2023
4 checks passed
@cowtowncoder cowtowncoder added this to the 2.15.0-rc3 milestone Apr 6, 2023
@JooHyukKim JooHyukKim deleted the Enhance-StdNodeBasedDeserializer-to-support-readerForUpdating branch May 22, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance StdNodeBasedDeserializer to support readerForUpdating
2 participants