Forward reference handling #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
January 13, 2014 10:07
…lization with object id.
…wn at end of processing.
cowtowncoder
added a commit
that referenced
this pull request
Jan 13, 2014
Forward reference handling
|
Great progress! I hope to have a look soon -- this can be one of key features for 2.4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first implementation of forward reference handling, with test cases. There's also test cases in the failing packages that demonstrates the current lack of support that I know of. Currently properties of an Array type, ArrayBlockingQueue and EnumMap are not implemented, due to lack of time. Each custom container deserializer must handle unresolved forward reference, but the recipe is the same (look at CollectionDeserializer and MapDeserializer).
Also, I didn't have to modify IdKey as I first thought.
Fixes #351