-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow primitive array deserializer to be captured by DeserializerModifier
#4219
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
src/test/java/com/fasterxml/jackson/databind/deser/BeanDeserializerModifier4216Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package com.fasterxml.jackson.databind.deser; | ||
|
||
import static com.fasterxml.jackson.databind.BaseMapTest.jsonMapperBuilder; | ||
import static org.junit.Assert.assertEquals; | ||
import com.fasterxml.jackson.databind.BeanDescription; | ||
import com.fasterxml.jackson.databind.DeserializationConfig; | ||
import com.fasterxml.jackson.databind.JsonDeserializer; | ||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import com.fasterxml.jackson.databind.module.SimpleModule; | ||
import com.fasterxml.jackson.databind.type.ArrayType; | ||
import java.util.concurrent.atomic.AtomicInteger; | ||
import org.junit.jupiter.api.Test; | ||
|
||
/** | ||
* Unit test for [databind#4216] : Primitive array deserializer cannot being captured by DeserializerModifier | ||
*/ | ||
public class BeanDeserializerModifier4216Test | ||
{ | ||
|
||
static class WrapperBean4216 { | ||
public Byte[] objArr; | ||
public byte[] primArr; | ||
} | ||
|
||
@Test | ||
public void testModifierCalledTwice() throws Exception | ||
{ | ||
// Given : Configure and construct | ||
AtomicInteger counter = new AtomicInteger(0); | ||
ObjectMapper objectMapper = jsonMapperBuilder() | ||
.addModules(getSimpleModuleWithCounter(counter)) | ||
.build(); | ||
|
||
// Given : Set-up data | ||
WrapperBean4216 test = new WrapperBean4216(); | ||
test.primArr = new byte[]{(byte) 0x11}; | ||
test.objArr = new Byte[]{(byte) 0x11}; | ||
String sample = objectMapper.writeValueAsString(test); | ||
|
||
// When | ||
objectMapper.readValue(sample, WrapperBean4216.class); | ||
|
||
// Then : modifyArrayDeserializer should be called twice | ||
assertEquals(2, counter.get()); | ||
} | ||
|
||
private static SimpleModule getSimpleModuleWithCounter(AtomicInteger counter) { | ||
SimpleModule module = new SimpleModule(); | ||
module.setDeserializerModifier( | ||
new BeanDeserializerModifier() { | ||
@Override | ||
public JsonDeserializer<?> modifyArrayDeserializer(DeserializationConfig config, | ||
ArrayType valueType, BeanDescription beanDesc, JsonDeserializer<?> deserializer) | ||
{ | ||
// Count invocations | ||
counter.incrementAndGet(); | ||
return deserializer; | ||
} | ||
}); | ||
return module; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> else if? I can change that actually. n/m