Add new option to handle properties not part of current active @JsonView
#4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa! This is AWESOME! Getting to solve old AND "Most wanted" issue(s). Well done. |
That's just how it should be, awesome! |
|
We'd need a PR to change defaults (and Javadoc) for 3.0 ( |
| // [databind#4108]: fields in other views to be considered as unknown properties | ||
| if (ctxt.isEnabled(DeserializationFeature.FAIL_ON_UNEXPECTED_VIEW_PROPERTIES)){ | ||
| ctxt.reportInputMismatch(handledType(), | ||
| String.format("Input mismatch while deserializing %s. Property '%s' is not part of current active view [%s]", |
There was a problem hiding this comment.
Just realized one idea: should this suggest disabling of feature to allow?
(not 100% sure but might be helpful, esp. when 3.0 changes default to enabled)
There was a problem hiding this comment.
Right, not only we state the problem, but also inform a possible solution. Makes sense, will try to propose a improved version! 👍🏼
Will do 👍🏼 cc @cowtowncoder |
cowtowncoder
added a commit
to FasterXML/jackson-dataformats-text
that referenced
this pull request
Jan 13, 2024
…e.FAIL_ON_UNEXPECTED_VIEW_PROPERTIES enabled by default in 3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves both #4108 and #437