Issue #175 - implement array with indicator indentation flag

[dswiecki]

Solves #175

[cowtowncoder]

Sounds like a useful addition (haven't reviewed change in detail but makes sense).
Just one quick note: since it is an API addition, it must go in a new minor version; in this case 2.12.0.
Timing works well as I am about to release first release candidate.

So, branch to merge would need to be 2.12.

[cowtowncoder]

As per not on PR itself, new features need to be added in a minor version, not patch (as per SemVer guidance)

[dswiecki]

updated to 2.12.0

[cowtowncoder]

Ok; ready to merge once I get CLA (see notes on issue), and PR gets rebased against 2.12 (to add a new feature).

Thank you once again for contributing this!

[dswiecki]

Updated PR, unfortuanetely can't rename branch - it has to be named 2.11 but it's based on 2.12. I've also sent CLA.

[cowtowncoder]

@dswiecki np wrt name, only matters what it merges against. Will have a quick re-read; received CLA.

[cowtowncoder]

@dswiecki Works great for 2.12, although there is a problem with 3.0 (master) -- looks like the new snakeyaml-engine does not have method setIndentWithIndicator in DumpSettingsBuilder, and I am not sure what the equivalent might be.
I was wondering if you know what might be the replacement there? If not, we can ask @asomov for help too.

[asomov]

@dswiecki Indeed, this is not yet ported to snakeyaml-engine. I will do as soon as I can. Feel free to create an issue for snakeyaml-engine: https://bitbucket.org/asomov/snakeyaml-engine/issues?status=new&status=open

[cowtowncoder]

@asomov created https://bitbucket.org/asomov/snakeyaml-engine/issues/27/support-snakeyaml

[asomov]

@cowtowncoder delivered in version 2.2
https://search.maven.org/artifact/org.snakeyaml/snakeyaml-engine/2.2/bundle

[cowtowncoder]

@asomov Excellent, update master to use 2.2, option added!

[asomov]

@cowtowncoder I am terribly sorry. Even though we have high test coverage a regression happen in SnakeYAML Engine version 2.2
New lines in the Windows format (\r\n) are not always respected properly.
There is already a fix in version 2.2.1
Can you please use the fixed version of SnakeYAML Engine ? Should I create a PR for the version change ?

[cowtowncoder]

@asomov Sure PR would be good if you have time.

[asomov]

@cowtowncoder done: #234