Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing header columns with Feature.FAIL_ON_MISSING_HEADER_COLUMNS #353

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

malteo
Copy link
Contributor

@malteo malteo commented Nov 9, 2022

Fixes #352

@malteo malteo force-pushed the allow-missing-header-columns branch from 07f4946 to 0313ff5 Compare November 9, 2022 11:43
@malteo malteo marked this pull request as ready for review November 9, 2022 11:44
@cowtowncoder
Copy link
Member

Excellent, thank you @malteo! Would be happy to merge this for 2.14.1. There is only one thing needed -- if not already done -- I'd need CLA before the first contribution (it'll work for any and all future contributions).
CLA is here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(there's also Corporate-CLA if need be)

and the usual way is to print, fill & sign, scan/photo, email to info at fasterxml dot com.

Once I have that I can merge this in.

Thank you once again for providing a patch -- it's unfortunate this fell through the cracks (I must have forgotten to follow through with configurability) but thanks to you it can be resolved relatively quickly.

@cowtowncoder cowtowncoder added cla-needed PR looks good (although may also require code review), but CLA needed from submitter csv labels Nov 16, 2022
@malteo
Copy link
Contributor Author

malteo commented Nov 16, 2022

done!

@cowtowncoder cowtowncoder removed the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Nov 17, 2022
@cowtowncoder cowtowncoder changed the title Allow missing header columns Allow missing header columns with Feature.FAIL_ON_MISSING_HEADER_COLUMNS Nov 17, 2022
@cowtowncoder cowtowncoder merged commit 53cf263 into FasterXML:2.14 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS has no effect
2 participants