[DRAFT] validate deep nesting #394
Conversation
| @@ -1403,11 +1409,16 @@ public ByteArrayBuilder _getByteArrayBuilder() | |||
| return _byteArrayBuilder; | |||
| } | |||
|
|
|||
| protected void _startArray(CsvSchema.Column column) | |||
| protected void _startArray(CsvSchema.Column column) throws UncheckedIOException | |||
There was a problem hiding this comment.
Is there a reason for this not to expose IOException?
There was a problem hiding this comment.
changed just now - I'm not sure if this PR is really useful though, I can't really see how you can nest CSV or JavaProperties - I'm going to concentrate on use cases like Smile and CBOR first - YAML is covered by SnakeYAML LoaderOPtions (so like jackson-dataformat-xml, the argument is if we need 2 ways to police the depth, SnakeYAML has a default depth limit of 50).
There was a problem hiding this comment.
Ah. Yeah, good point. In theory in future we might create nested Objects etc. But even then... seems unlikely & can cross that bridge if we get there.
For Properties it's bit different since there is the path splitting so one can actually create keys to create whatever depth.
And YAML is interesting as limits are needed but... provided natively. So can/should postpone handling changes there too I think.
TOML, once again is... its own thing.
So I think Properties are one to consider, yet less important than Smile, CBOR. Can't do it for Ion I suspect.
Protobuf doesn't have constructs for infinite recursion I don't think?
|
closing in favour of #397 |
relies on FasterXML/jackson-core#943