TreeSand load improvement #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackmystack
force-pushed
the
tree-stand-load-improvement
branch
4 times, most recently
from
188d955
to
3a4a6b9
Compare
|
I redid the commits since they were very rough and incoherent. |
stackmystack
force-pushed
the
tree-stand-load-improvement
branch
2 times, most recently
from
feb5228
to
ed76923
Compare
DerekStride
reviewed
May 24, 2024
stackmystack
force-pushed
the
tree-stand-load-improvement
branch
3 times, most recently
from
4ea0705
to
cbd9591
Compare
We used to load only `so` files in a specific path if provided through config. This patch adds 2 things: 1. Parsers for Mac and Linux. 2. Automatic lookup through defaults if no config is provided.
When the test suite fails it opens an rdbg session, and most of the time, when debugging, I'd like to just get back to my code and work with it. It would have been OK if a ^C or a ^D would do it. But the problem is worst: my terminal keeps getting out of sync. Uncomment that line if you want that debugging functionality. It's now opt-in.
We still have some cross-ref issues with markdown.
stackmystack
force-pushed
the
tree-stand-load-improvement
branch
from
cbd9591
to
a4897c3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
TreeStand::Utils::Printerfrom aStringIOcreated each time we callpretty_print, to something fixed in the printer class, and configurable as well, throughTreeStand.config.io.@DerekStride I did these changes while working with TreeStand, and I acknowledge the fact they could be broken into different PRs, but I just did them in a single one for convenience.
I would love to have your feedback, as I did some things on the spot and I might be missing something.