Corrupted zip bug fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alayouni
commented
Apr 15, 2017
alayouni
commented
- Added source file name header to fix source submission bug
- Replaced buggy Files#probeContentType call by Tika#detect
- Added Tika dependency to pom
… buggy Files#probeContentType call by Tika#detect
|
Thanks for the pull request ! All the update sound ok to me. I will just merge next thursday, because diffusing artifact on maven, and repackaging CLI tools requires private key that is located on my office computer :). Nice work ! |
|
Any a chance for the new release before round 1B? |
|
Yes sorry i had a busy week :). I will do it tomorrow ! |
|
ok thanks! |
|
Pull request has been merged, reviewed, and deployed into maven central under 1.4.11 version. Google code jam CLI application has been upgraded to 1.4.1 accordingly (https://github.com/Faylixe/googlecodejam-cli/releases/tag/v1.4.1). I added you in the contributor list in the repository README. Thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.