Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"edit tree" button wording #2

Closed
blackrim opened this issue Sep 12, 2013 · 6 comments
Closed

"edit tree" button wording #2

blackrim opened this issue Sep 12, 2013 · 6 comments

Comments

@blackrim
Copy link
Member

not sure if it is best to have "edit tree" or "view tree" or "edit/view" or "view" and then when you get to the view you can click "edit". either way, I wanted to view the tree and figured edit was the button for me, but there may be a better way to present that.

@chinchliff
Copy link
Member

View tree seems fine. It will probably make it a but clearer that it is
going to a different page

On Thursday, September 12, 2013, Stephen Smith wrote:

not sure if it is best to have "edit tree" or "view tree" or "edit/view"
or "view" and then when you get to the view you can click "edit". either
way, I wanted to view the tree and figured edit was the button for me, but
there may be a better way to present that.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2
.

@blackrim
Copy link
Member Author

if we did view, we could put a button at the top of the tree view that is edit that would activate the buttons that allow editing? otherwise they could be inactive. i can do that if that seems like a good idea. otherwise, you are just browsing

@chinchliff
Copy link
Member

Eh, I don't think it's bad to have the buttons active. You still have to
click one to do anything. Generally I think people will be ok with that. I
do think "view tree" is better than edit tree though for the source view
page

On Thursday, September 12, 2013, Stephen Smith wrote:

if we did view, we could put a button at the top of the tree view that is
edit that would activate the buttons that allow editing? otherwise they
could be inactive. i can do that if that seems like a good idea. otherwise,
you are just browsing


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-24319895
.

@blackrim
Copy link
Member Author

Yeah, it is just making sure that folks know that they are actually
changing the tree for real. Not like change and see and then edit if you
like (if you know what I mean). Either way, it is fine for now just to
change to view

On Thu, Sep 12, 2013 at 9:51 AM, chinchliff notifications@github.comwrote:

Eh, I don't think it's bad to have the buttons active. You still have to
click one to do anything. Generally I think people will be ok with that. I
do think "view tree" is better than edit tree though for the source view
page

On Thursday, September 12, 2013, Stephen Smith wrote:

if we did view, we could put a button at the top of the tree view that
is
edit that would activate the buttons that allow editing? otherwise they
could be inactive. i can do that if that seems like a good idea.
otherwise,
you are just browsing


Reply to this email directly or view it on GitHub<
https://github.com/FePhyFoFum/otu/issues/2#issuecomment-24319895>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-24320685
.

@chinchliff
Copy link
Member

We could alert them when they enter the tree view page that any changes
will be permanent

On Thursday, September 12, 2013, Stephen Smith wrote:

Yeah, it is just making sure that folks know that they are actually
changing the tree for real. Not like change and see and then edit if you
like (if you know what I mean). Either way, it is fine for now just to
change to view

On Thu, Sep 12, 2013 at 9:51 AM, chinchliff <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

Eh, I don't think it's bad to have the buttons active. You still have to
click one to do anything. Generally I think people will be ok with that.
I
do think "view tree" is better than edit tree though for the source view
page

On Thursday, September 12, 2013, Stephen Smith wrote:

if we did view, we could put a button at the top of the tree view that
is
edit that would activate the buttons that allow editing? otherwise
they
could be inactive. i can do that if that seems like a good idea.
otherwise,
you are just browsing


Reply to this email directly or view it on GitHub<
https://github.com/FePhyFoFum/otu/issues/2#issuecomment-24319895>
.


Reply to this email directly or view it on GitHub<
https://github.com/FePhyFoFum/otu/issues/2#issuecomment-24320685>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-24321237
.

@chinchliff
Copy link
Member

The source view page has been changed, it now says "View Tree" (and the button is primary instead of warning.

For alerts about tree editing buttons, I have created #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants