Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from central. #1

Merged
merged 36 commits into from
Feb 4, 2024
Merged

Merge from central. #1

merged 36 commits into from
Feb 4, 2024

Conversation

FeZoli
Copy link
Owner

@FeZoli FeZoli commented Nov 13, 2023

No description provided.

This commit aims to fix some readability issues in regards to those are visually
impaired, mainly colorblindness.

- contrast of the fg/bg have been increased
- link and text have been brightened
- container objects (like the nav, <pre> background) contrast the primary
  background more.

Signed-off-by: Evan Sarris <evan@theoryware.net>
When a window is unmapped, awesome stops tracking it, possibly
leaving stale grabs behind.  These grabs can be activated if the
window is mapped again without awesome’s knowledge.  This results
in a locked pointer until the grab window is destroyed.

Fix by releasing passive grabs before untracking a client window.
…when_dismissed_by_user

Send a default action when notification is closed by user
Redraw drawable when changing geometry
Previously, things like `awful.screenshot` would print a false
positive warning because the `item.name` was fixed after the
linting rather than before it.
Those were written before the doc linting was merged.
They can now use multiple files. Some of the templates are getting
unmaintainable and would benefit from being multiple small widgets.
Previously, it would raw_set properties like floating. This means the
signals and the result of calling `awful.client.property.get` was
different. Some older code uses `awful.client.property.get` or
`awful.client.object.get_floating` rather than `c.floating`.

With this change, all native properties should be handled as so
and all non native properties set at the end, after `__newindex`
is defined.

The list of properties was extracted using

    cat client.c
        | tail -n100
        | grep -Eo '["][^"]+["]'
        | grep -Eo '[^"]+'
Release all grabs when unmanaging windows
This will be used soon by a nice CSS inspired image slicer
container/layout.

They have a limitation inherited from Cairo of only working on a
single axis. This isn't important for 99% of the use case.
To be used by `wibox.container.border`, which is a specialized imagebox.
Before, the CSS had to be inline. Now that the border container uses
this code, it makes sense to make it more flexible.
The `textbox` already has the equivalent. This will soon be used
by the new `wibox.container.border` widget.
Rather than bloat the `background` container with another 1k lines,
a new container is added. The goal is to implement CSS-style slicing
for the background images. The container also allows to place
generic widgets on each sides and corners of the container.

The main use case for this container is to replace the old
`awful.titlebar` API with `awful.decoration`. That new module will
allow a central client widget to be surrounded by widgets rather than
have 4 separate drawing areas. The border container is designed to
make complex border+titlebar setup trivial.
It is now handled by the `wibox.container.border`. The current
implementation had many unhandled corner case and is less
flexible than the new API.

Some might argue deprecating the background from a background
container is... strange. This is true. However, keeing all
use case within the same codebase would make it too large.

The `gears.shape` support is incompatible with the border
widgets (which are used to implement the background images).
This is a feature request from the chat. Right now, only deprecated
hacks allow this to be implemented. This is a valid use case and
must be supported for HiDPI use cases.
* added surface crop function

* added busted tests

* added devShell Flake

* Revert "added devShell Flake"

This reverts commit 0acb3d4.

* general purpose crop added

* cleanup

* merged functions, added tests

* replaced gdebug.print_error with error

* clearer error message for crop

Co-authored-by: Lucas Schwiderski <4508454+sclu1034@users.noreply.github.com>

* make error message shorter

* surface.crop: Fix doc warnings.

---------

Co-authored-by: Paul Schneider <74120050+paulhersch@users.noreply.github.com>
Co-authored-by: Paul Schneider <paul.schneider2@student.uni-halle.de>
Co-authored-by: Lucas Schwiderski <4508454+sclu1034@users.noreply.github.com>
Elv13 and others added 6 commits December 31, 2023 15:27
Co-authored-by: Aire-One <aireone@aireone.xyz>
Use GITHUB_OUTPUT envvar instead of set-output command as the latter is deprecated
Fix typo in object.lua documentation
@FeZoli FeZoli merged commit ba69dfe into FeZoli:master Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants