commits from bitcoin/master #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors zmq-related test skipping logic into distinct functions.
src/leveldb/build_detect_platform shows how upstream defines them. These platform may not be able to fully build or run Bitcoin, but defining all known to leveldb saves future hassle. Now that all possible platforms are enumerated, specifying an unknown one is an error.
GetBalance() can now take an ismine filter, which is passed down to GetAvailableCredit. This allows GetBalance to be used to get watch-only balances.
Mark everything else static or in an anonymous namespace.
…n soon after Pruning forces a chainstate flush, which can defeat the dbcache and harm performance significantly.
To avoid repeated implementations.
And document in the header.
Moves OutputType into its own module
Makes AddAndGetDestinationForScript use a generic CKeyStore rather than the wallet, and makes it always add the script to the keystore, rather than only adding related (redeem) scripts.
FeatherCoin
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tests] skip rpc_zmq functional test as necessary
bitcoin/bitcoin#13645
[wallet] ScanforWalletTransactions should mark input txns as dirty
bitcoin/bitcoin#12944
qa: Fix some TODOs in p2p_segwit
bitcoin/bitcoin#13626
Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain
bitcoin/bitcoin#13630
build: add missing leveldb defines
bitcoin/bitcoin#13659
Fix get balance
bitcoin/bitcoin#13566
[net] Tighten scope in net_processing
bitcoin/bitcoin#13417
During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after
bitcoin/bitcoin#11658
[moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe
bitcoin/bitcoin#13651
Update createmultisig RPC to support segwit
bitcoin/bitcoin#13072
[tests] Remove accounts from wallet_importprunedfunds.py
bitcoin/bitcoin#13138
Update gitian-build.sh for docker
bitcoin/bitcoin#13368