Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Chicago Bike Demo #157

Merged
merged 246 commits into from Sep 1, 2020
Merged

Adds Chicago Bike Demo #157

merged 246 commits into from Sep 1, 2020

Conversation

jeff-hernandez
Copy link
Collaborator

@jeff-hernandez jeff-hernandez commented Aug 18, 2020 •
edited

Adds the Chicago Bike Demo to the docs.

@jeff-hernandez
initial updates
cebe265
@jeff-hernandez
adds command to build docs
df91423
@jeff-hernandez
updates predict next purchase
d3aed93
@jeff-hernandez
updates predict rul
b0709c7
@jeff-hernandez
updates params for predict next purchase
c819cc4
@jeff-hernandez
updates params for predict next purchase
e82fe35
@jeff-hernandez
updates doc reqs and removes reference links
8a3d177
@jeff-hernandez
orders doc requirements
c8104cb
@jeff-hernandez
adds requirement
f833561
@jeff-hernandez
updates predict rul
afb9a53
@jeff-hernandez
updates predict next purchase
b098d4e
@jeff-hernandez
removes matplotlib in requirements
eabe7f3
@jeff-hernandez
pins matplotlib version
49b9eac
@jeff-hernandez
updates predict next purchase
2e3dd10
@jeff-hernandez
initial updates
250ebe4
@jeff-hernandez
adds command to build docs
c246ef1
@jeff-hernandez
updates predict next purchase
bec84ad
@jeff-hernandez
updates predict rul
f085f1f
@jeff-hernandez
updates params for predict next purchase
d8ade15
@jeff-hernandez
updates params for predict next purchase
e5595ac
@jeff-hernandez
updates doc reqs and removes reference links
574e34a
@jeff-hernandez
orders doc requirements
4cce566
@jeff-hernandez
adds requirement
5f9989a
@jeff-hernandez
updates predict rul
8897525
@jeff-hernandez
updates predict next purchase
f02d65e
@jeff-hernandez
removes matplotlib in requirements
f3ad7db
@jeff-hernandez
pins matplotlib version
8651c23
@jeff-hernandez
updates predict next purchase
a4896d9
@jeff-hernandez
updates notebook
78dabbd
@jeff-hernandez
Merge branch 'updates_demos' of github.com:FeatureLabs/compose into u…
ea66180 
…pdates_demos
@jeff-hernandez
Copy link
Collaborator Author

@thehomebrewnerd thanks for the great feedback! The PR has been updated and is ready for another review.

@jeff-hernandez
Copy link
Collaborator Author

I also updated the other notebooks based on the same feedback.

@jeff-hernandez
Copy link
Collaborator Author

I think it would be helpful to have the notebooks on google colab.

@jeff-hernandez
Copy link
Collaborator Author

@thehomebrewnerd the section for making predictions has been updated and is ready for review.

@jeff-hernandez jeff-hernandez added the documentation Improvements or additions to documentation label Aug 26, 2020
@thehomebrewnerd
Copy link
Contributor

@jeff-hernandez Another thought in terms of the discussion - instead of using the term "future data", maybe we should call this "new data" instead, if we are going to use this approach. The word "future" could be a little confusing. How could we obtain future data to make predictions?

Instead, I think what we are trying to illustrate is that after we have built a model we might acquire additional data, and we can combine this "new" data with the old data to create a new feature matrix that we can then be used to make predictions.

thehomebrewnerd
thehomebrewnerd previously approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-hernandez Noticed a couple minor spelling/wording issues, but otherwise looking good!

docs/source/examples/predict_bike_trips.ipynb Outdated Show resolved Hide resolved
docs/source/examples/predict_next_purchase.ipynb Outdated Show resolved Hide resolved
docs/source/examples/predict_turbofan_degredation.ipynb Outdated Show resolved Hide resolved
thehomebrewnerd
thehomebrewnerd previously approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more spelling issues to fix, but otherwise looks good!

docs/source/examples/predict_next_purchase.ipynb Outdated Show resolved Hide resolved
docs/source/examples/predict_turbofan_degredation.ipynb Outdated Show resolved Hide resolved
thehomebrewnerd
thehomebrewnerd approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-hernandez jeff-hernandez merged commit 66e04a1 into main Sep 1, 2020
@jeff-hernandez jeff-hernandez deleted the adds_chicago_bike_demo branch September 1, 2020 20:33
@jeff-hernandez jeff-hernandez mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 left review comments

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeff-hernandez @thehomebrewnerd @kmax12