Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize_entity errors when copying time index variable to new, non-time-indexed entity #740

Closed
rwedge opened this issue Sep 13, 2019 · 0 comments · Fixed by #749
Closed
Assignees
Labels
bug Something isn't working

Comments

@rwedge
Copy link
Contributor

rwedge commented Sep 13, 2019

Bug/Feature Request Description

Using copy_variables to copy the time index column of the base entity to the new entity errors now due to how we addressed #497.

Reproducible example:

from featuretools.tests.testing_utils import make_ecommerce_entityset

es = make_ecommerce_entityset()
es.normalize_entity(base_entity_id="customers",
                    new_entity_id="cancel_reason",
                    index="cancel_reason",
                    make_time_index=False,
                    copy_variables=["signup_date"])
ValueError: DatetimeTimeIndex variable signup_date must be set using time_index parameter

We should probably change the variable type from DatetimeTimeIndex to Datetime when it is copied over (same for NumericTimeIndex / Numeric)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants