Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use randomly generated names in retail csv #233

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

Seth-Rothschild
Copy link
Contributor

In this PR we replace the customer_id floats with randomly generated names in the retail demo dataset.

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          71       71           
  Lines        7671     7671           
=======================================
  Hits         7183     7183           
  Misses        488      488
Impacted Files Coverage Δ
featuretools/demo/retail.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3bf5...4a2bc8d. Read the comment docs.

@Seth-Rothschild Seth-Rothschild changed the title Use randomly generated names in retail csv (WIP) Use randomly generated names in retail csv Aug 27, 2018
@Seth-Rothschild
Copy link
Contributor Author

Changing customer_id to customer_name in csv and modifying the associated step in normalize entity.

@Seth-Rothschild Seth-Rothschild changed the title (WIP) Use randomly generated names in retail csv Use randomly generated names in retail csv Aug 28, 2018
@kmax12
Copy link
Contributor

kmax12 commented Aug 29, 2018

Looks good. Merging

@kmax12 kmax12 merged commit 57b34b3 into master Aug 29, 2018
@Seth-Rothschild Seth-Rothschild deleted the customer-names-in-retail branch August 30, 2018 15:41
@kmax12 kmax12 mentioned this pull request Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants