Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last time index #33

Merged
merged 8 commits into from
Nov 21, 2017
Merged

Last time index #33

merged 8 commits into from
Nov 21, 2017

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Nov 20, 2017

Adds last_time_index property to Entity. For each instance in the entity, the last time index refers to the most recent event associated with that instance. For entities without child entities, this would be the time index of that entity. For an instance of an entity with children, it would be the most recent last_time_index among associated instances on the child entities. When using training windows while calculating a feature matrix, instances with last_time_indexes that are not as recent as the edge of the training window will excluded from the data.

@codecov-io
Copy link

Codecov Report

Merging #33 into master will decrease coverage by 1.11%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   88.05%   86.93%   -1.12%     
==========================================
  Files          73       73              
  Lines        6730     6851     +121     
==========================================
+ Hits         5926     5956      +30     
- Misses        804      895      +91
Impacted Files Coverage Δ
featuretools/demo/mock_customer.py 14.28% <0%> (-0.43%) ⬇️
featuretools/demo/flight.py 25.92% <0%> (-1%) ⬇️
...utational_backend/test_calculate_feature_matrix.py 98.34% <100%> (+0.07%) ⬆️
featuretools/entityset/entity.py 76.47% <100%> (+0.63%) ⬆️
...aturetools/tests/entityset_tests/test_pandas_es.py 99.72% <100%> (ø) ⬆️
featuretools/entityset/entityset.py 87.26% <100%> (-0.33%) ⬇️
featuretools/demo/retail.py 100% <100%> (ø) ⬆️
featuretools/entityset/serialization.py 18.84% <0%> (-77.94%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418fdf...da21d8f. Read the comment docs.

@kmax12 kmax12 merged commit aaf504d into master Nov 21, 2017
@kmax12 kmax12 mentioned this pull request Nov 21, 2017
@kmax12 kmax12 deleted the last_time_index branch December 20, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants