Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sklearn DFS Transformer #343

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Update Sklearn DFS Transformer #343

merged 1 commit into from
Dec 10, 2018

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Dec 10, 2018

This PR updates the test case for the sklearn DFS transformer to no check for the number of output features. it also updates the default values

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #343 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   95.35%   95.35%   -0.01%     
==========================================
  Files          74       74              
  Lines        7792     7791       -1     
==========================================
- Hits         7430     7429       -1     
  Misses        362      362
Impacted Files Coverage Δ
featuretools/wrappers/sklearn.py 95.65% <ø> (ø) ⬆️
...eaturetools/tests/wrappers/test_sklearn_wrapper.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d367818...6c80af9. Read the comment docs.

@kmax12 kmax12 merged commit 047aed5 into master Dec 10, 2018
@rwedge rwedge mentioned this pull request Dec 17, 2018
@rwedge rwedge deleted the sklearn branch July 2, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant