Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean primitive changes #395

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Mean primitive changes #395

merged 4 commits into from
Feb 4, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 1, 2019

Fixes #393, changes ignore_nans to skipna, and set skipna=True by default

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #395 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   95.78%   95.79%   +<.01%     
==========================================
  Files          90       90              
  Lines        7882     7896      +14     
==========================================
+ Hits         7550     7564      +14     
  Misses        332      332
Impacted Files Coverage Δ
...ools/primitives/standard/aggregation_primitives.py 95.9% <100%> (+0.15%) ⬆️
...aturetools/tests/primitive_tests/test_agg_feats.py 99.2% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be812d8...1b62dc2. Read the comment docs.

@kmax12 kmax12 self-requested a review February 1, 2019 23:01
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmax12 kmax12 merged commit 6c7d876 into master Feb 4, 2019
@rwedge rwedge mentioned this pull request Feb 15, 2019
@rwedge rwedge deleted the mean-primitive-changes branch February 19, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants