Remove unecessary time_last variable #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just grouped on this column, so it should be equal to the group identifier. This removes the variable which was called time_last, but renames the group id to now be time_last.
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 96.31% 96.31% -0.01%
==========================================
Files 115 115
Lines 9156 9155 -1
==========================================
- Hits 8819 8818 -1
Misses 337 337
Continue to review full report at Codecov.
|
|
@CJStadler let's wait to merge until after the next release |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just grouped on this column, so it should be equal to the group
identifier. This removes the variable which was called
time_last, butrenames the group id to now be
time_last.