change time delta to weeks #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 121 121
Lines 10939 10939
=======================================
Hits 10737 10737
Misses 202 202
Continue to review full report at Codecov.
|
rwedge
reviewed
Dec 2, 2019
docs/source/changelog.rst
Outdated
| @@ -7,6 +7,7 @@ Changelog | |||
| * Fixes | |||
| * Raise error when given wrong input for ignore_variables (:pr:`826`) | |||
| * Changes | |||
| * Replace pd.timedelta time units with weeks (:pr:`822`) | |||
There was a problem hiding this comment.
Can we change this to "Replace pd.timedelta time units that were deprecated"?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Month and year units are deprecated.
replace them with weeks instead.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.