Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change time delta to weeks #822

merged 4 commits into from Dec 2, 2019


Copy link

systemshift commented Nov 20, 2019

Pull Request Description

Month and year units are deprecated.
replace them with weeks instead.

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

systemshift added 2 commits Nov 20, 2019

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #822 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #822   +/-   ##
  Coverage   98.15%   98.15%           
  Files         121      121           
  Lines       10939    10939           
  Hits        10737    10737           
  Misses        202      202
Impacted Files Coverage Δ
...ests/primitive_tests/ 100% <100%> (ø) ⬆️
.../tests/primitive_tests/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f72d96...588706d. Read the comment docs.

@@ -7,6 +7,7 @@ Changelog
* Fixes
* Raise error when given wrong input for ignore_variables (:pr:`826`)
* Changes
* Replace pd.timedelta time units with weeks (:pr:`822`)

This comment has been minimized.

Copy link

rwedge Dec 2, 2019


Can we change this to "Replace pd.timedelta time units that were deprecated"?

rwedge approved these changes Dec 2, 2019
Copy link

rwedge left a comment

Looks good!

@rwedge rwedge merged commit 8aad8ee into FeatureLabs:master Dec 2, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 98.15%)
codecov/project 98.15% (+0%) compared to 5f72d96
license/cla Contributor License Agreement is signed.
test_all_python_versions Workflow: test_all_python_versions
@systemshift systemshift deleted the systemshift:change_time_delta branch Dec 2, 2019
@rwedge rwedge mentioned this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.