Replaced type string with camel to snake-case function #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2020 14:11
…onversion. Updated the schema version to reflect this as the LatLong and ZIPcode variable types were affected
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 98.27% 98.27% -0.01%
==========================================
Files 119 119
Lines 11076 11059 -17
==========================================
- Hits 10885 10868 -17
Misses 191 191
Continue to review full report at Codecov.
|
tuethan1999
changed the title
rwedge
reviewed
May 27, 2020
docs/source/changelog.rst
Outdated
| @@ -11,7 +11,7 @@ Changelog | |||
| * Fixes | |||
| * Fix errors with Equals and NotEquals primitives when comparing categoricals or different dtypes (:pr:`968`) | |||
| * Normalized type_strings of ``Variable`` classes so that the ``find_variable_types`` function produces a | |||
| dictionary with a clear key to name transition (:pr:`982`) | |||
| dictionary with a clear key to name transition (:pr:`982`)(:pr:`996`) | |||
rwedge
reviewed
May 27, 2020
|
|
||
|
|
||
| class ClassNameDescriptor(object): | ||
| """Descriptor to derive the a variable's type_string from it's class name |
There was a problem hiding this comment.
I think the description could be a little more general, we might use this descriptor for other classes besides Variable and it's subclasses
rwedge
reviewed
May 28, 2020
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| class ClassNameDescriptor(object): | |||
| """Descriptor to derive the a variable's type_string from it's class name | |||
| """Descriptor to convert a class's name from camelcase to snakcase | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Replaced the
Variableclass and subclass'stype_stringwith a function that does a camel to snake case conversion based on the class name. Updated the schema version to reflect this as the LatLong and ZIPcode variable types were affected