Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AutoMLSearch object as another parameter in search callbacks #1156

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

christopherbunn
Copy link
Contributor

For both start_iteration_callback and add_results_callback, the AutoMLSearch object passed in as the third parameter.

Resolves #1095

@christopherbunn christopherbunn changed the title Added AutoMLSearch object as another parameter in callback Added AutoMLSearch object as another parameter in search callbacks Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #1156 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         195      195           
  Lines       11554    11554           
=======================================
  Hits        11544    11544           
  Misses         10       10           
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.58% <100.00%> (ø)
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)
.../automl_tests/test_automl_search_classification.py 100.00% <100.00%> (ø)
...ests/automl_tests/test_automl_search_regression.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0be178...e1dd9c6. Read the comment docs.

@christopherbunn christopherbunn marked this pull request as ready for review September 10, 2020 16:45
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopherbunn Looks good to me!

@christopherbunn christopherbunn merged commit c5239a8 into main Sep 11, 2020
@christopherbunn christopherbunn deleted the 1095_automlsearch_callback_copy branch September 11, 2020 15:32
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a copy of the AutoMLSearch object in add_results_callback
2 participants