Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function call on Exploring search results page in docs #604

Merged
merged 5 commits into from
Apr 9, 2020
Merged

Fixed function call on Exploring search results page in docs #604

merged 5 commits into from
Apr 9, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 8, 2020

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #604 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         118      118           
  Lines        4453     4453           
=======================================
  Hits         4403     4403           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e294c...ae7788f. Read the comment docs.

@gsheni gsheni changed the title fixed function Fixed function call on Exploring search results page in docs Apr 8, 2020
@gsheni gsheni added the documentation Improvements or additions to documentation label Apr 8, 2020
jeremyliweishih
jeremyliweishih approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsheni gsheni merged commit 4dc2f3b into master Apr 9, 2020
@gsheni gsheni deleted the fix_wrong_feature_importance_graph_doc branch April 9, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

Assignees

@gsheni gsheni

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs page, Exploring search results, has an incorrect function
2 participants
@gsheni @jeremyliweishih