Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define DataCheck and DataChecks classes #739

Merged
merged 48 commits into from
May 5, 2020
Merged

Define DataCheck and DataChecks classes #739

merged 48 commits into from
May 5, 2020

Conversation

angela97lin
Copy link
Contributor

Update from #725, closes #369

@angela97lin
init
12772f4
@angela97lin
changelog
5035cef
@angela97lin
Merge branch 'master' into 369_data_checks_classes
7454344
@angela97lin
init more tests
13572a5
@angela97lin
api ref
8210e57
@angela97lin
linting and cleanup
41da8aa
@angela97lin
cleanup
6854c81
@angela97lin
fix tests
8d9ab4d
@angela97lin
test codecov again
a4b8a5a
@angela97lin
Merge branch 'master' into 369_data_checks_classes
7413be5
@angela97lin
make test more legit
0715cb4
@angela97lin
merge
8e10718
@angela97lin
merge
29e5fa9
@angela97lin
update test
eacae03
@angela97lin
add test
d25fe83
@angela97lin
add
a2e1b81
@angela97lin
Merge branch 'master' into 369_data_checks_classes
8ae9cdc
@angela97lin
Merge branch 'master' into 369_data_checks_classes
bd178c1
@angela97lin
cleanup
c75ba1c
@angela97lin
minor cleanup
974b49a
@angela97lin
fixing docstr
45d7cc7
@angela97lin
add name and tests
7935593
@angela97lin
updating via comments, still some work to do
eaccec0
@angela97lin
removing verbose flag
5fd5b03
@angela97lin
addressing comments cont
2e0c237
@angela97lin
add docstr
15d6869
@angela97lin
fix check, add docstr
ffd3d5c
@angela97lin
add another test
6322ffc
@angela97lin
codecob
40479d8
@angela97lin
add napoleon setting
3f554e3
dsherry
dsherry approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👍 this is great. I left some more suggestions, but after that this is ready to go!

@angela97lin angela97lin requested a review from dsherry May 5, 2020 04:00
@angela97lin
Copy link
Contributor Author

@dsherry Thanks for all of your comments! They were super helpful; I know you already approved this PR but there were a few open threads so I'd love it if you could look things over one last time before I merge this in :D

@dsherry
Copy link
Contributor

dsherry commented May 5, 2020

@angela97lin sure! I just wrote back to your latest comments.

@angela97lin angela97lin merged commit 16e1363 into master May 5, 2020
@dsherry dsherry deleted the 369_data_checks_classes branch October 29, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Checks API: DataCheck and DataChecks classes
2 participants
@angela97lin @dsherry