Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to use release_notes.rst instead of changelog.rst #942

Merged
merged 8 commits into from Jul 17, 2020
Merged

Update docs to use release_notes.rst instead of changelog.rst #942

merged 8 commits into from Jul 17, 2020

Conversation

angela97lin
Copy link
Contributor

After the docs overhaul, we should update docs to use release_notes.rst instead of changelog.rst!

@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited

Codecov Report

Merging #942 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         170      170           
  Lines        8640     8640           
=======================================
  Hits         8629     8629           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c47429...83c83f8. Read the comment docs.

dsherry
dsherry approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@angela97lin
Copy link
Contributor Author

Going to wait until #943 or RtD warnings are fixed to make sure nothing in this change is breaking :)

@angela97lin angela97lin marked this pull request as ready for review July 17, 2020 19:29
@dsherry
Copy link
Contributor

dsherry commented Jul 17, 2020

Good idea @angela97lin ! Let's get main green first

@angela97lin angela97lin added this to the July 2020 milestone Jul 17, 2020
angela97lin
angela97lin commented Jul 17, 2020
View reviewed changes
docs/source/install.ipynb
@@ -26,7 +26,7 @@
"\n",
"```bash\n",
"pip install evalml --no-dependencies\n",
"pip instal -r core-requirements.txt\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaking this in 😂

angela97lin
angela97lin commented Jul 17, 2020
View reviewed changes
docs/source/release_notes.rst
Comment on lines -1 to -2
.. _changelog:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like removing this doesn't break things and we're not sure what this does so removing!

@angela97lin
Copy link
Contributor Author

Green on master (https://readthedocs.com/projects/feature-labs-inc-evalml/builds/370599/) and this branch (https://readthedocs.com/projects/feature-labs-inc-evalml/builds/370601/), merging!

@angela97lin angela97lin merged commit 85a04b7 into main Jul 17, 2020
@angela97lin angela97lin deleted the update_release_notes branch September 24, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angela97lin @dsherry