Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ReadtheDocs warning failure regarding embedded gif #943

Merged
merged 9 commits into from Jul 17, 2020
Merged

Fixes ReadtheDocs warning failure regarding embedded gif #943

merged 9 commits into from Jul 17, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jul 17, 2020 •
edited

@angela97lin angela97lin self-assigned this Jul 17, 2020
@angela97lin angela97lin added this to the July 2020 milestone Jul 17, 2020
@angela97lin angela97lin mentioned this pull request Jul 17, 2020
Merged
@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited

Codecov Report

Merging #943 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         170      170           
  Lines        8640     8640           
=======================================
  Hits         8629     8629           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8147aff...34199ef. Read the comment docs.

@angela97lin angela97lin changed the title Fix RtD warning failure Fix RtD warning failure with embedding gif in Jupyter notebook Jul 17, 2020
@angela97lin angela97lin changed the title Fix RtD warning failure with embedding gif in Jupyter notebook Fixes ReadtheDocs warning failure regarding embedded gif Jul 17, 2020
@angela97lin angela97lin marked this pull request as ready for review July 17, 2020 20:41
freddyaboulton
freddyaboulton approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@angela97lin angela97lin merged commit 8c47429 into main Jul 17, 2020
@angela97lin angela97lin deleted the ange_doc_warning_fix branch July 17, 2020 20:45
dsherry
dsherry reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@angela97lin angela97lin mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry left review comments

@freddyaboulton freddyaboulton freddyaboulton approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angela97lin @dsherry @freddyaboulton