Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move datetime formatting to Datetime LogicalType #216

Merged
merged 10 commits into from
Oct 7, 2020
Merged

Conversation

tamargrey
Copy link
Contributor

closes #198

Removes 'datetime_format' from config and adds a datetime_format to the Datetime logical type so that any different formats can be indicated for each column.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #216 into main will decrease coverage by 0.04%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   99.86%   99.82%   -0.05%     
==========================================
  Files          22       22              
  Lines        2218     2224       +6     
==========================================
+ Hits         2215     2220       +5     
- Misses          3        4       +1     
Impacted Files Coverage Δ
woodwork/config.py 100.00% <ø> (ø)
woodwork/tests/data_column/test_data_column.py 100.00% <ø> (ø)
woodwork/logical_types.py 96.15% <80.00%> (-1.11%) ⬇️
woodwork/data_column.py 100.00% <100.00%> (ø)
woodwork/data_table.py 100.00% <100.00%> (ø)
woodwork/tests/data_table/test_datatable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7bd5e...abc63f0. Read the comment docs.

@thehomebrewnerd
Copy link
Contributor

@tamargrey I didn't review this in detail, but we will also want to update the new config options guide in the docs to remove the references to the global datetime format config variable. We will probably also want to include some documentation on how to work with logical types that have options specified, but that can be a separate issue and PR (we will also need this for Ordinal and other logical types that will eventually take options)

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things. Looks good overall.

woodwork/config.py Show resolved Hide resolved
@gsheni gsheni self-requested a review October 7, 2020 21:16
@tamargrey tamargrey merged commit 7df2154 into main Oct 7, 2020
@gsheni gsheni deleted the datetime-format branch October 7, 2020 21:55
@gsheni gsheni mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move datetime format config to be on the Datetime Logical Type
3 participants