Rename DataColumn.to_pandas to DataColumn.to_series #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2550 2550
=========================================
Hits 2550 2550
Continue to review full report at Codecov.
|
gsheni
approved these changes
Oct 23, 2020
gsheni
reviewed
Oct 23, 2020
| * Documentation Changes | ||
| * Add conda install instructions (:pr:`305`, :pr:`309`) | ||
| * Testing Changes | ||
|
|
||
| Thanks to the following people for contributing to this release: | ||
| :user:`ctduffy`, :user:`gsheni`, : | ||
| Thanks to the following people for contributing to this release: |
There was a problem hiding this comment.
We should add that this is a breaking change? Users will have to rename their function call?
There was a problem hiding this comment.
Yes - we should. I'll update.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the DataColumn method
to_pandastoto_seriesto better reflect return types when using non-pandas dataframes for input. Also updated documentation where this was mentioned related to columns.