Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select logical types #96

Merged
merged 5 commits into from Sep 15, 2020
Merged

Select logical types #96

merged 5 commits into from Sep 15, 2020

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Sep 14, 2020 •
edited by gsheni

@tamargrey tamargrey changed the title Select ltypes Select logical types Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020

The author of this PR, tamargrey, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at success@codecov.io with any questions.

@gsheni gsheni self-requested a review September 14, 2020 22:30
gsheni
gsheni suggested changes Sep 15, 2020
View reviewed changes
data_tables/data_table.py Show resolved Hide resolved
data_tables/data_table.py Outdated Show resolved Hide resolved
data_tables/tests/data_table/test_datatable.py Outdated Show resolved Hide resolved
data_tables/tests/data_table/test_datatable.py Outdated Show resolved Hide resolved
gsheni
gsheni approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tamargrey tamargrey merged commit 386bbd8 into main Sep 15, 2020
@gsheni gsheni deleted the select-ltypes branch September 15, 2020 23:34
@gsheni gsheni mentioned this pull request Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

Assignees

@tamargrey tamargrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add select_ltypes to DataTables to allow user to select Data Columns
2 participants
@tamargrey @gsheni