Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor computation of primitive lists in DeepFeatureSynthesis __init__ #2399

Open
sbadithe opened this issue Dec 13, 2022 · 0 comments
Open

Refactor computation of primitive lists in DeepFeatureSynthesis __init__ #2399

sbadithe opened this issue Dec 13, 2022 · 0 comments
Labels
enhancement Improvement to an existing feature refactor Work being done to refactor code. tech debt additional rework caused by choosing an easy solution now

Comments

@sbadithe
Copy link
Contributor

When building the following lists, there is a lot of code duplication:

  • self.groupby_trans_primitives
  • self.agg_primitives
  • self.where_primitives
  • self.trans_primitives

Furthermore, refactoring this logic outside of the __init__ would help make the code more expressive and testable.
@sbadithe sbadithe changed the title Refactor DeepFeatureSynthesis __init__ Refactor computation of primitive lists in DeepFeatureSynthesis __init__ Dec 13, 2022
@sbadithe sbadithe mentioned this issue Dec 13, 2022
Closed
@sbadithe sbadithe added enhancement Improvement to an existing feature refactor Work being done to refactor code. labels Dec 13, 2022
@gsheni gsheni added the tech debt additional rework caused by choosing an easy solution now label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature refactor Work being done to refactor code. tech debt additional rework caused by choosing an easy solution now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsheni @sbadithe