Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom primitive kwarg fix #38

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Custom primitive kwarg fix #38

merged 2 commits into from
Dec 8, 2017

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Dec 7, 2017

Setting custom primitive function inputs via keyword arguments no longer changes keyword arguments for all instances of that custom primitive. Also renamed PrimitiveBase._get_name to PrimitiveBase.generate_name to avoid confusiong with PrimitiveBase.get_name

@codecov-io
Copy link

Codecov Report

Merging #38 into master will increase coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage    88.1%   88.12%   +0.01%     
==========================================
  Files          71       71              
  Lines        6792     6828      +36     
==========================================
+ Hits         5984     6017      +33     
- Misses        808      811       +3
Impacted Files Coverage Δ
featuretools/entityset/entity.py 76.47% <ø> (ø) ⬆️
...sts/feature_function_tests/test_direct_features.py 100% <100%> (ø) ⬆️
...turetools/primitives/aggregation_primitive_base.py 95.55% <100%> (+0.1%) ⬆️
featuretools/primitives/primitive_base.py 76.94% <100%> (ø) ⬆️
featuretools/primitives/cum_transform_feature.py 97.59% <100%> (ø) ⬆️
...ols/tests/feature_function_tests/test_agg_feats.py 98.47% <100%> (+0.12%) ⬆️
featuretools/primitives/binary_transform.py 83.83% <100%> (ø) ⬆️
featuretools/primitives/transform_primitive.py 97.3% <100%> (+0.47%) ⬆️
featuretools/primitives/aggregation_primitives.py 92.1% <100%> (ø) ⬆️
featuretools/primitives/direct_feature.py 95.45% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8864e3b...4928030. Read the comment docs.

@kmax12
Copy link
Contributor

kmax12 commented Dec 8, 2017

Good change. Looks good to merge

@kmax12 kmax12 merged commit b20069b into master Dec 8, 2017
@kmax12 kmax12 mentioned this pull request Dec 12, 2017
@kmax12 kmax12 deleted the custom_primitive_kwarg_fix branch December 20, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants